Responsibilities

Authors

• Add a short and concise description of the changeset where feasible

• Keep changesets small, split large changesets

• Choose appropriate reviewers

• Check common issues before adding reviewers

Reviewers

• Read the description and all comments before reviewing

• Avoid ambiguity in comments

• Explain your reasoning

• Add references (Documentation, style guide, best practices)

• Tend towards accepting the changeset if it improves the overall state of the code base, even if it’s not perfect

• Base reviews on technical facts and data, avoid requesting changes based on personal preference

Reviewers & Authors

• Communicate clearly and respectfully:

• Code Review Guide | Respectful communication

• Embrace the code review process as a way to tech and learn as well as to improve the quality of the code base